Added Erc1155 NFT for ETH CELO and BSC #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatumio
suggested changes
May 19, 2021
| import {Currency} from './Currency'; | ||
| import { DeployErc1155 } from './DeployErc1155'; | ||
|
|
||
| export class CeloDeployErc1155 extends DeployErc1155 { |
There was a problem hiding this comment.
Stick to the name MultiToken instead of Erc1155
src/model/request/DeployErc1155.ts
Outdated
| import {Currency} from './Currency'; | ||
| import {PrivateKeyOrSignatureId} from './PrivateKeyOrSignatureId'; | ||
|
|
||
| export class DeployErc1155 extends PrivateKeyOrSignatureId { |
| } from '../model'; | ||
| import {CeloUpdateCashbackErc721} from '../model/request/CeloUpdateCashbackErc721'; | ||
| import {UpdateCashbackErc721} from '../model/request/UpdateCashbackErc721'; | ||
| import { CeloUpdateCashbackErc721 } from '../model/request/CeloUpdateCashbackErc721'; |
There was a problem hiding this comment.
Multi token stuff should not be inside nft/index.ts, but in its own directory multitoken/index.ts
tatumio
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.