From da396b65a354f2b63c7f3f2ca09ceac02cc493cc Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Wed, 4 Dec 2024 09:41:51 -0800 Subject: [PATCH] Remove l4re from the unsigned char operating system list As noted in https://github.com/rust-lang/rust/pull/132975#issuecomment-2484645240, the default for userland apps is to follow the architecture defaults, the -funsigned-char flag only applies to kernel builds. --- core/src/ffi/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/ffi/mod.rs b/core/src/ffi/mod.rs index a9be4ebea4e19..827c8ca15d4ed 100644 --- a/core/src/ffi/mod.rs +++ b/core/src/ffi/mod.rs @@ -97,7 +97,8 @@ mod c_char_definition { // in clang/lib/Driver/ToolChains/Clang.cpp): // - PowerPC uses unsigned char for all targets except Darwin // - Arm/AArch64 uses unsigned char except for Darwin and Windows - // - L4RE builds with -funsigned-char on all targets + // Note: the L4RE kernel builds with -funsigned-char on all targets, but + // we only have a target for userspace apps so it follows the architectures. if #[cfg(all( not(windows), not(target_vendor = "apple"), @@ -113,7 +114,6 @@ mod c_char_definition { target_arch = "riscv32", target_arch = "s390x", target_arch = "xtensa", - target_os = "l4re", ) ))] { pub type c_char = u8;