You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is reported by @trflynn89 in #79
I copy his report below:
Hey @FrankYFTang - While implementing this, I came across a small issue. I think WeekInfoOfLocale needs to be updated to match the [[FirstDayOfWeek]] changes. [[FirstDayOfWeek]] can now be an arbitrary string, but steps 4-5 of WeekInfoOfLocale state:
4. Let fw be loc.[[FirstDayOfWeek]].
5. If fw is not undefined, then
a. Set r.[[FirstDay]] to fw.
Where r.[[FirstDay]] is an "Integer value between 1 and 7". So I think there needs to be a step to convert fw from a string to an integer here.
The text was updated successfully, but these errors were encountered:
This is reported by @trflynn89 in #79
I copy his report below:
Hey @FrankYFTang - While implementing this, I came across a small issue. I think
WeekInfoOfLocale
needs to be updated to match the[[FirstDayOfWeek]]
changes.[[FirstDayOfWeek]]
can now be an arbitrary string, but steps 4-5 ofWeekInfoOfLocale
state:Where
r.[[FirstDay]]
is an "Integer value between 1 and 7". So I think there needs to be a step to convertfw
from a string to an integer here.The text was updated successfully, but these errors were encountered: