Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of pending steps no longer displayed in status #630

Closed
bobcatfish opened this issue Mar 18, 2019 · 2 comments
Closed

Status of pending steps no longer displayed in status #630

bobcatfish opened this issue Mar 18, 2019 · 2 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@bobcatfish
Copy link
Collaborator

Expected Behavior

When running kubectl get taskruns -o yaml for a TaskRun that is in progress, the steps section should display a pending status for all steps that have not yet started executing.

Actual Behavior

Since we switched from init containers to regular containers, the steps section will show only completed steps and not in progress steps, for example:

  status:
    conditions:
    - lastTransitionTime: 2019-03-18T17:38:28Z
      reason: Building
      status: Unknown
      type: Succeeded
    podName: publish-run-pod-f761a6
    startTime: 2019-03-18T17:37:53Z
    steps:
    - terminated:
        containerID: docker://684ef788d066f5185c9bdb1e7dad2b6bb25be1e8b9aeb673cb216fe316fedf77
        exitCode: 0
        finishedAt: 2019-03-18T17:37:56Z
        reason: Completed
        startedAt: 2019-03-18T17:37:56Z

Steps to Reproduce the Problem

  1. Create a Task with mulitple steps
  2. Create a TaskRun to invoke it
  3. Run kubectl get taskrun -o yaml <my task run> and observe the steps
@bobcatfish bobcatfish added kind/bug Categorizes issue or PR as related to a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Mar 18, 2019
@abayer
Copy link
Contributor

abayer commented Mar 18, 2019

Yeah, we've got a lot of things that don't quite work right for containers vs init containers - I'm quite wary of moving Jenkins X to a container-using version of this. =)

@vdemeester
Copy link
Member

Indeed, it's still looking at init containers here… I'm fixing it as part of #252 but I'll most likely do 2 PRs then (one to fix this issue, the other one for removing build ref)

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants