Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Enhencement] Indicator doesn't respect monochrome style (Ubuntu) #1199

Closed
keunes opened this issue Oct 18, 2015 · 21 comments
Closed

[UI Enhencement] Indicator doesn't respect monochrome style (Ubuntu) #1199

keunes opened this issue Oct 18, 2015 · 21 comments
Labels

Comments

@keunes
Copy link

keunes commented Oct 18, 2015

Standard, all indicators in Ubuntu are monochrome. Telegram is an odd one in that area with its coloured background. Though I like the icon as such, I don't like that it's at odds with the rest. But more importantly this renders a problem when the Dash is pulled forward, as the icon becomes a plain circle:
screenshot from 2015-10-18 14 35 24 [normal]
screenshot from 2015-10-18 14 35 13 [with dash open]

It would be nice if the icon could be the paper aeroplane with transparent background.

@telegramdesktop
Copy link
Collaborator

What is "Dash"?

@keunes
Copy link
Author

keunes commented Oct 18, 2015

The Dash is a part of the Unity interface of Ubuntu. When pressing the super-key (aka Windows key), you get a window in which you can search all installed programmes, content from the web and local files. More: official info and images of the dash

@telegramdesktop
Copy link
Collaborator

@keunes Didn't see that problem with the icon there.. Color currently is used for red / gray counter, but perhaps it could be done better.

@keunes
Copy link
Author

keunes commented Oct 18, 2015

Which problem don't you see? I indicated two problems:

  • inconsistency with the indicator area (all icons are monochrome except Telegram)
  • icon is indistinguishable when Dash is open (it's a plain circle, you can't see it's Telegram)

Do I understand it correctly that the background colour indicates a status? What do red and grey indicate?

An option for Telegram to indicate statuses would be to have a light-grey (like the other icons) aeroplane for regular status and to A) make the aeroplane blue or B) put a circle around the aeroplane, in case there's a new message. Then the icon could be dark grey if you're not logged-in (or if there's something else wrong such as not being connected to the internet).

Other examples:
The bluetooth icon indicates that it's on by being light grey (as is the case above), and when it's off the icon is dark grey. The coffeecup icon (of a program that protects against screensaver) has coffee damp above the cup when it's turned on. The battery icon is filled depending on the battery percentage and turns red when battery status is critical. Dropbox is dark-grey when syncing is paused, and has an exclamation mark in the middle when there's an error.

@auchri
Copy link
Contributor

auchri commented Oct 18, 2015

Is it because of #1002?

@telegramdesktop
Copy link
Collaborator

@keunes I didn't see the blank circle instead of blue icon before in Ubuntu, didn't pay attention to it, only saw it when you described the issue.

Red background of the unread messages counter icon indicates that there are unread messages in not muted conversations, gray unread messages counter icon indicates that all the unread messages are in conversations with muted notifications.

@keunes
Copy link
Author

keunes commented Oct 18, 2015

@auchri: nope, that has to do with the location of the icon within the Ubuntu filesystem, this is about the actual design of the icon.

@auchri auchri added the linux label Oct 18, 2015
@DeadMetaler
Copy link

White circle it's normal. If you want to change this, icon must be repaint with transparent Airplane logo inside circle, but it can't be white.

@keunes
Copy link
Author

keunes commented Oct 28, 2015

@DeadMetaler I would argue the white circle is not normal; indeed it works as expected from the Ubuntu side, but it is not normal in the sense that these icons are supposed to still be recognisable with the Dash open.

Indeed it is possible to make the Airplane logo transparent, but I prefer my previous proposal (to get rid of the circle and just have the aeroplane as icon). Your proposal would lead to an airplane in any colour (depending on the user's theme settings), something which you want to avoid.

An option for Telegram to indicate statuses would be to have a light-grey (like the other icons) aeroplane for regular status and to A) make the aeroplane blue or B) put a circle around the aeroplane, in case there's a new message. Then the icon could be dark grey if you're not logged-in (or if there's something else wrong such as not being connected to the internet).

Here's how I imagined it would look like (ltr: new unmuted message, active, not active):
t_icon_inbar
t_icon_indash
Note that it doesn't look as neat as it's just a mock-up and image boundaries are a bit blurry.

I must admit that I didn't account for a counter in my proposal, but actually I wouldn't miss it. If needed, it could be added similar to current practice.

@cpriego
Copy link

cpriego commented Dec 1, 2015

Yes please!, I've been struggling with this for a long time. There was a temporary solution with the help of https://github.com/bil-elmoussaoui/Hardcode-Tray script but the indicator code changed and it no longer works.

@bilelmoussaoui
Copy link

@cpriego i'm the dev of Hardcode-Tray, can you report that there so i can see if can fix it ?Thanks 👍

@alexeydemin
Copy link

5 months gone since issue report, every week I get new desktop version but the problem still exists...

@bicodegas
Copy link

Don't know if this helps or if it is a workaround, but it's working for now.
I installed Telegram from the atareo-team ppa (I'm using Xubuntu Trusty). I changed the icons on ~/.TelegramDesktop/tdata/ticons/ like this:
captura de ecra_2016-07-02_02-07-14

And now Telegram is using them:
captura de ecra_2016-07-02_02-11-58

captura de ecra_2016-07-02_02-15-43

(now if I only had a Faenza-Dark type Telegram indicator icon, I would be happy)

@rival82
Copy link

rival82 commented Aug 15, 2016

heres some custom tray icons i made to address this annoyance.

https://github.com/rival82/mono_dark_tray-icons

@AndydeCleyre
Copy link
Contributor

AndydeCleyre commented Nov 28, 2016

Right now I'm using this to get a grey tray icon until there's a new message. You may need a different source image.

#!/bin/bash
set -e

cd ~/.TelegramDesktop/tdata/ticons
rm -r *

# blue -> grey (no messages)
convert /usr/share/pixmaps/telegram.png -modulate 51,0,100 ./ico_22.png

# grey (muted, no messages):
cp ico_22.png icomute_22_0.png

# blue (one message)
cp /usr/share/pixmaps/telegram.png ico_22_1.png

# blue (muted, one message):
cp /usr/share/pixmaps/telegram.png icomute_22_1.png

# blue (more messages)
for f in {2..2000}; do ln -s ico_22_1.png ico_22_$f.png; done
for f in {2..2000}; do ln -s icomute_22_1.png icomute_22_$f.png; done

@cibersheep
Copy link

This is really cool.
It seems that the ico_22_X.png is ¿created on the fly? It would be nice to just modify the original though.
Does someone know if I'm right, where is it?

@timorei
Copy link

timorei commented Feb 20, 2017

The one thing I am wondering about: Is there any current desktop environment that's not defaulting to monochrome systray icons? Windows 10 has monochrome icons, plasma, unity, gnome-shell, macos,... They all seem to actually prefer monochrome icons.

It might be worth considering switching to monochrome tray icons as default.

@bilelmoussaoui
Copy link

@Feichtmeier You don't really need to copy anything by yourself, it's done automatically :) (if you're using a theme that does include icons for telegram)

@bilelmoussaoui
Copy link

Can you reopen that issue so I can fix it ?

@Aokromes
Copy link
Collaborator

Maybe better #1908 ?

@github-actions
Copy link

github-actions bot commented Mar 8, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests