bugfix: orphans are not totally collected when Remove #177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Summary:
Remove
operation will leave some orphans not collected. So these orphans would never be pruned from database. So many nodeDB operations would get the wrong result, liketraverse
,traversePrefix
,traverseNodes
,size()
, etc.Steps To Reproduce:
The test will failed because the
Remove
only collect 3 orphans instead of the expected 4.The tree looks like this
The orphans should be [5, 5, 4, 3], but we got [5,4,3] instead. The inner node
5
is lost.