-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back S3_VERIFY_SSL environment variable #1790
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
fb5099a
to
f79e7f4
Compare
@yongtang Can you take a look at this? Would be great to have this functionality back :) |
@fsonntag thanks for the contribution - can you sign the CLA as was shown ? |
@yongtang Is it possible to push this through? :) I think the failed CI is not related to this change! |
Hi tensorflow-io team, Since this fix isn't incorporated in the latest pip version nor the nightly (last candidate was from March). When will the next pip release happen? Are there any plans to fix the nightly soon? Thanks! |
I need this on my Kubeflow on-prem production environment. I got some issue to use tensorflow-io with an on-prem minio s3 bucket. Please bring back the S3_VERIFY_SSL env setting asap. |
#1343 removed the environment variable
S3_VERIFY_SSL
.Even though it's discouraged to disable SSL verification, it is still useful to do so in development environments. So it would be great to bring this back.