Get label colour from raw confusion matrix #4206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was choosing the label colour based on the row-normalized confusion matrix values, but the background colour of each square is chosen from the un-normalized confusion matrix. This causes problems for under-represented labels where all the squares in one row are light, but the label colour switches to white if any entry in the row has more than 0.5 relative to the row.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@nfelt Can you take a quick look at this? I was not able to assign a reviewer myself... Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
This code was choosing the label colour based on the row-normalized confusion matrix values, but the background colour of each square is chosen from the un-normalized confusion matrix.
This causes problems for under-represented labels where all the squares in one row are light, but the label colour switches to white if any entry in the row has more than 0.5 relative to the row.
Technical description of changes
Use the un-normalized confusion matrix when deciding which colour to give a label.
Screenshots of UI changes
Before (left) and after (right) the change, using data from a different run than in the guide. Note how the text of the leftmost square in the middle row is now visible.