graph: color large graphs by 'none' instead of 'structure' by default (4) #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psybuzz
force-pushed
the
pz-colorbynone4
branch
2 times, most recently
from
11b34c7 to
53d6f16
Compare
stephanwlee
reviewed
Mar 6, 2021
tensorboard/plugins/graph/tf_graph_dashboard/tf-graph-dashboard.ts
Outdated
Show resolved
Hide resolved
|
Thanks for attaching the table. It was insightful. |
stephanwlee
approved these changes
Mar 9, 2021
Comment on lines
34
to
37
| const MAX_GRAPH_SIZE_TO_COMPUTE_TEMPLATES = { | ||
| maxNodeCount: 10000, | ||
| maxEdgeCount: 10000, | ||
| }; |
There was a problem hiding this comment.
style thing: often, consts invert the casing :P
i.e.,
const MaxGraphSizeToComputeTemplates = {
MAX_NODE_COUNT: 10000,
MAX_Edge_COUNT: 10000,
};There was a problem hiding this comment.
Done. I'll remember for next time!
psybuzz
commented
Mar 9, 2021
Comment on lines
34
to
37
| const MAX_GRAPH_SIZE_TO_COMPUTE_TEMPLATES = { | ||
| maxNodeCount: 10000, | ||
| maxEdgeCount: 10000, | ||
| }; |
There was a problem hiding this comment.
Done. I'll remember for next time!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Color by structure" mode can be very expensive to compute,
often consistently freezing TensorBoard for minutes with some large
graphs. This introduces a new "Color by none", which does not color
groups by structure.
Opening TensorBoard's Graphs with a small graph will still default to
"structure" coloring, but when loading a large graph, it will
automatically switch to "none", requiring the user to opt-in by clicking
on the radio button.
The condition for a large graph is "10K+ nodes && 10K+ edges", but
this can be tuned. These were determined by examining several
graphs manually:
Screenshot
Diffbase: #4741
Followup: none