time series: move the fit button to header #4856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scalar line chart in the time series has had the feature where we automatically fit domain to the new data when it is unaltered. However, because it was hidden inside the overflow menu and because there was no clear visual indication when the chart will fit to the domain or not, it was largely confusing. With the recent changes to make it more salient with `title` and `disabled` on the button, we improved in this area but was still not too obvious. To fix this problem, we are now moving the control out of the overflow menu into the chart header so there is a clearer visual difference between domains overridden vs. not.
psybuzz
approved these changes
Apr 13, 2021
| FIT_TO_DOMAIN: By.css('[aria-label="Fit line chart domains to data"]'), | ||
| }; | ||
|
|
||
| it('resets domain when user clicks on reset button', fakeAsync(() => { |
There was a problem hiding this comment.
Just checking, since this test case doesn't do any flush()ing, can fakeAsync be dropped?
There was a problem hiding this comment.
It is used in the createComponent or one of these utils (I tried and it threw an error).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scalar line chart in the time series has had the feature where we
automatically fit domain to the new data when it is unaltered. However,
because it was hidden inside the overflow menu and because there was no
clear visual indication when the chart will fit to the domain or not, it
was largely confusing. With the recent changes to make it more salient
with
titleanddisabledon the button, we improved in this area butwas still not too obvious.
To fix this problem, we are now moving the control out of the overflow
menu into the chart header so there is a clearer visual difference
between domains overridden vs. not.