Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to include no-data example #5163

Merged
merged 4 commits into from
Aug 4, 2021
Merged

Update README.md to include no-data example #5163

merged 4 commits into from
Aug 4, 2021

Conversation

MalcolmSlaney
Copy link
Contributor

Added an example of what good and bad event files might contain.

As a less than full-time user of TB, I see this problem a lot, and I would really love to see good and bad examples so I more easily know what I'm seeing.

Alternative suggestions welcome.

  • Motivation for features / changes: It wasn't clear to this user what an empty event file looked like. Let alone a good one.

  • Technical description of changes: Added the --inspect output from a good and a bad event file.

  • Screenshots of UI changes: N/A

  • Detailed steps to verify changes work correctly (as executed by you): Documentation change only.

  • Alternate designs / implementations considered: Would love to see better examples.

Added an example of what good and bad event files might contain.

As a less than full-time user of TB, I see this problem a lot, and I would really love to see good and bad examples so I more easily know what I'm seeing.

Alternative suggestions welcome.
@google-cla google-cla bot added the cla: yes label Jul 29, 2021
Copy link
Contributor

@nfelt nfelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! One clarification suggested

README.md Outdated
@@ -254,6 +254,30 @@ tensorboard in inspect mode to inspect the contents of your event files.

`tensorboard --inspect --logdir DIRECTORY_PATH`

An empty event file (from a Keras job that starts output at batch 2) might look like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth a little clarification here that this event file isn't exactly "empty" (in that it does contain some events, as indicated by the non-zero steps) but that it doesn't show any summary data.

E.g. perhaps word as something like:

The output for an event file corresponding to a blank TensorBoard may still sometimes show a few steps, representing a few initial events that aren't shown by TensorBoard (for example, when using the Keras TensorBoard callback):

[output]

In contrast, the output for an event file with more data might look like this:

[output]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Much better now.

@nfelt nfelt merged commit bd8641e into tensorflow:master Aug 4, 2021
yatbear pushed a commit to yatbear/tensorboard that referenced this pull request Mar 27, 2023
* Update README.md to include no-data example

Added an example of what good and bad event files might contain.

As a less than full-time user of TB, I see this problem a lot, and I would really love to see good and bad examples so I more easily know what I'm seeing.

Alternative suggestions welcome.

* Better description of the state of the event files.

* Better explanation of empty event file

* Removing white space at the end of the line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants