From 4950c3ba5ef4acc8e9851862b54d9ea4be80dd0d Mon Sep 17 00:00:00 2001 From: Stephan Lee Date: Thu, 5 Aug 2021 08:36:08 -0700 Subject: [PATCH] line chart: zoom instruction show on top of other Especially with the customizable interactive view, the line chart interactive view is no longer on top of all the other DOM. This makes our zoom instruction which should appear above all is getting clipped or getting masked by other components. This change simply uses z-index: 1 (we do not use it elsewhere so 1 is sufficient; we rely on DOM ordering for the most part) to lift the DOM up. --- .../line_chart_v2/sub_view/line_chart_interactive_view.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tensorboard/webapp/widgets/line_chart_v2/sub_view/line_chart_interactive_view.scss b/tensorboard/webapp/widgets/line_chart_v2/sub_view/line_chart_interactive_view.scss index e70af81bb5..d1c9a59bd0 100644 --- a/tensorboard/webapp/widgets/line_chart_v2/sub_view/line_chart_interactive_view.scss +++ b/tensorboard/webapp/widgets/line_chart_v2/sub_view/line_chart_interactive_view.scss @@ -100,7 +100,9 @@ th { right: 0; top: 10px; transition: opacity 0.5s; + z-index: 1; } + .instruction-content { background: rgba(0, 0, 0, 0.6); border-radius: 5px;