router: support conditional navigations and empty experiment names #5216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
approved these changes
Aug 9, 2021
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
…iases (tensorflow#5216) This includes 2 changes to the app router. - The 'compare' route now accepts a URL that defines experiments with an 'id' and no display 'name' / alias. For example, 'http://localhost/compare/:unnamedExpId,baseline:secondNamedExpId' - Registering a `ProgrammaticalNavigation` now allows providing a lambda which may conditionally return `null`, to indicate that a navigation should not occur when the specified action is fired. These changes are a step towards allowing a TensorBoard app to craft a URL that automatically uses default experiment aliases computed at runtime without the URL having to specify them. Googlers, see b/195683550 and proof of concept cl/389664527
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
…iases (tensorflow#5216) This includes 2 changes to the app router. - The 'compare' route now accepts a URL that defines experiments with an 'id' and no display 'name' / alias. For example, 'http://localhost/compare/:unnamedExpId,baseline:secondNamedExpId' - Registering a `ProgrammaticalNavigation` now allows providing a lambda which may conditionally return `null`, to indicate that a navigation should not occur when the specified action is fired. These changes are a step towards allowing a TensorBoard app to craft a URL that automatically uses default experiment aliases computed at runtime without the URL having to specify them. Googlers, see b/195683550 and proof of concept cl/389664527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes 2 changes to the app router.
an 'id' and no display 'name' / alias. For example,
'http://localhost/compare/:unnamedExpId,baseline:secondNamedExpId'
ProgrammaticalNavigationnow allows providing alambda which may conditionally return
null, to indicate that anavigation should not occur when the specified action is fired.
These changes are a step towards allowing a TensorBoard app to craft a
URL that automatically uses default experiment aliases computed at
runtime without the URL having to specify them.
Googlers, see b/195683550 and proof of concept cl/389664527