timeseries: persist tag filter in the URL #5236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psybuzz
force-pushed
the
persist-tag
branch
2 times, most recently
from
d57dc1e to
60fd78f
Compare
japie1235813
approved these changes
Aug 17, 2021
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
The Time Series dashboard tag filter is now synced with the URL's "?tagFilter" query param. Manually tested that typing in the tag filter updates the URL, and that crafting a URL with "?tagFilter=batch" and navigating to it makes the dashboard show the appropriately matching cards. Googlers, see b/182797564.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
The Time Series dashboard tag filter is now synced with the URL's "?tagFilter" query param. Manually tested that typing in the tag filter updates the URL, and that crafting a URL with "?tagFilter=batch" and navigating to it makes the dashboard show the appropriately matching cards. Googlers, see b/182797564.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Time Series dashboard tag filter is now synced with the URL's
"?tagFilter" query param.
Manually tested that typing in the tag filter updates the URL, and
that crafting a URL with "?tagFilter=batch" and navigating to it
makes the dashboard show the appropriately matching cards.
Googlers, see b/182797564.
Blocked on: #5239