Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix wrapping of dropdown items #5242

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

psybuzz
Copy link
Contributor

@psybuzz psybuzz commented Aug 13, 2021

Long items within tb-dropdown are supposed to wrap onto multiple
lines. Our CSS was incorrectly using a selector without enough
specificity, and Angular was overriding our classname.

Before
image

After
image

@google-cla google-cla bot added the cla: yes label Aug 13, 2021
@psybuzz psybuzz requested a review from bmd3k August 13, 2021 21:41
@stephanwlee
Copy link
Contributor

Would it be at all possible to use native select instead of wrapping content? I have not seen many instances where there are multi-line formatting on <select>

@psybuzz
Copy link
Contributor Author

psybuzz commented Aug 13, 2021

Would it be at all possible to use native select instead of wrapping content? I have not seen many instances where there are multi-line formatting on <select>

The original motivation for making items wrap is so that very long experiment names in an experiment dropdown would be at least readable in their entirety. The longest tag names are usually not as long as the longest experiment names, but they happen to share the same component. The tradeoff is we either can show the full option text on multiple lines, or avoid wrapping entirely and lose the full name, which may help distinguish similar long experiment names. Could you confirm which is preferable?

<tb-dropdown> in the tag filter updates as the user types, so I think opening a native <select> would steal focus from the text input field, interrupting typing.

@psybuzz psybuzz merged commit d4b37e3 into tensorflow:master Aug 18, 2021
yatbear pushed a commit to yatbear/tensorboard that referenced this pull request Mar 27, 2023
Long items within tb-dropdown are supposed to wrap onto multiple
lines. Our CSS was incorrectly using a selector without enough
specificity, and Angular was overriding our classname.
dna2github pushed a commit to dna2fork/tensorboard that referenced this pull request May 1, 2023
Long items within tb-dropdown are supposed to wrap onto multiple
lines. Our CSS was incorrectly using a selector without enough
specificity, and Angular was overriding our classname.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants