timeseries: second draft of TS promotion #5291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds some messages and placeholders for the TimeSeries promotion. It also adds two buttons users can use to navigate to scalars, old experience, or dismiss the promotion.
japie1235813
approved these changes
Sep 3, 2021
| overflow: hidden; | ||
| } | ||
|
|
||
| .notice { | ||
| background-color: rgba(mat-color($mat-yellow, 200), 0.85); | ||
| border-bottom: 1px solid mat-color($mat-yellow, 500); | ||
| color: #000; |
There was a problem hiding this comment.
The text color and background contrast is a bit high to me. Can we change it to "rgb(33,33,33)" as other black in dashboard?
perhaps color: inherit;
There was a problem hiding this comment.
Cannot inherit since I don't want colors to change in the dark mode.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
This change adds some messages and placeholders for the TimeSeries promotion. It also adds two buttons users can use to navigate to scalars, old experience, or dismiss the promotion.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
This change adds some messages and placeholders for the TimeSeries promotion. It also adds two buttons users can use to navigate to scalars, old experience, or dismiss the promotion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds some messages and placeholders for the TimeSeries
promotion. It also adds two buttons users can use to navigate to
scalars, old experience, or dismiss the promotion.