Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeseries: keep all digits for step values in scalar cards #5325

Merged
merged 3 commits into from
Sep 22, 2021

Conversation

yatbear
Copy link
Member

@yatbear yatbear commented Sep 21, 2021

To make the step values more meaningful, e.g. display 1,001,001 instead of just 1M.

Visualization:

Screen Shot 2021-09-22 at 2 12 29 PM

Googlers, see issue.

#onduty

Copy link
Contributor

@stephanwlee stephanwlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely is not the scalable way so I think it would be much better to display their actual value.

Since TensorBoard is used in a scientific setting, even when very long, I think it is much nicer to show their actual value in full length especially in a tooltip.

As such, we want to use something like Intl.NumberFormat.

> new Intl.NumberFormat().format(10010000)
< // At the very least, ","s in between number lets you read the number much easily.
< '10,010,000'

@yatbear
Copy link
Member Author

yatbear commented Sep 22, 2021

This definitely is not the scalable way so I think it would be much better to display their actual value.

Since TensorBoard is used in a scientific setting, even when very long, I think it is much nicer to show their actual value in full length especially in a tooltip.

As such, we want to use something like Intl.NumberFormat.

> new Intl.NumberFormat().format(10010000)
< // At the very least, ","s in between number lets you read the number much easily.
< '10,010,000'

Done. Thanks!

@yatbear yatbear changed the title timeseries: keep 4 significant digits for step values with SI-suffix timeseries: keep all digits for step values in scalar cards Sep 22, 2021
@yatbear yatbear merged commit f6ec0a8 into tensorflow:master Sep 22, 2021
@yatbear yatbear deleted the d3 branch September 22, 2021 20:33
yatbear added a commit to yatbear/tensorboard that referenced this pull request Mar 27, 2023
dna2github pushed a commit to dna2fork/tensorboard that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants