line chart: fix bug where line does not update #5423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For SVG renderer, which is current default, when a line path updates while invisible, we never update its path leading to very subtle issue. Repro steps: 1. Find a scalar card with more than two runs (all toggled on here) 2. Toggle all runs off 3. Toggle on run on 4. Zoom in and change viewBox 5. Toggle on another run. Observe that the run line is positioned where it was in #1.
japie1235813
approved these changes
Nov 17, 2021
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
For SVG renderer, which is current default, when a line path updates while invisible, we never update its path leading to very subtle issue. Repro steps: 1. Find a scalar card with more than two runs (all toggled on here) 2. Toggle all runs off 3. Toggle on run on 4. Zoom in and change viewBox 5. Toggle on another run. Observe that the run line is positioned where it was in tensorflow#1.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
For SVG renderer, which is current default, when a line path updates while invisible, we never update its path leading to very subtle issue. Repro steps: 1. Find a scalar card with more than two runs (all toggled on here) 2. Toggle all runs off 3. Toggle on run on 4. Zoom in and change viewBox 5. Toggle on another run. Observe that the run line is positioned where it was in #1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SVG renderer, which is current default, when a line path updates
while invisible, we never update its path leading to very subtle issue.
Repro steps:
it was in (1).
Fixes b/206638910.