histogram: clean up v2 code #5443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt
approved these changes
Dec 1, 2021
|
|
||
| # Export V3 versions. | ||
| histogram_v3 = summary_v2.histogram_v3 | ||
|
|
||
| # Export the default versions. |
There was a problem hiding this comment.
Let's change this line to say "Export V3 versions." now?
| @@ -46,217 +38,6 @@ | |||
| DEFAULT_BUCKET_COUNT = 30 | |||
|
|
|||
|
|
|||
| def histogram_v2(name, data, step=None, buckets=None, description=None): | |||
There was a problem hiding this comment.
Now that we're removing histogram_v2, I think it'd make sense to rename histogram_v3 to just histogram (what the v2 one was called prior to the migration). We can then remove the histogram = histogram_v3 line at the bottom.
When we do that, it might make sense to add a #-style comment (not in the docstring, which is public, but just for our own reference) that mentions that this new histogram is actually an updated v3 format, not the v2 format, as the filename would imply.
There was a problem hiding this comment.
Renamed and added the comment.
yatbear
added a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
* clean up histogram v2 code
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
* clean up histogram v2 code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove V2 code.
Ran internally: cl/413690112
#histogram #tpu