scalar: manually set background to transparent #5567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
approved these changes
Feb 15, 2022
| @@ -289,6 +289,8 @@ export class ThreeRenderer implements ObjectRenderer<CacheValue> { | |||
| alpha: true, | |||
| } as WebGLContextAttributes) as WebGLRenderingContext, | |||
| }); | |||
| // Workaround to fix background transparency is not set propoerly in threejs WebGLRenderer. | |||
There was a problem hiding this comment.
Which property was supposed to make the background transparent? Is it the "alpha: true"? Can you mention that?
| @@ -289,6 +289,8 @@ export class ThreeRenderer implements ObjectRenderer<CacheValue> { | |||
| alpha: true, | |||
| } as WebGLContextAttributes) as WebGLRenderingContext, | |||
| }); | |||
| // Workaround to fix background transparency is not set propoerly in threejs WebGLRenderer. | |||
There was a problem hiding this comment.
Nite: propoerly => properly.
|
From the reply of three.js developers. mrdoob/three.js#23495 Also remove |
bmd3k
approved these changes
Feb 15, 2022
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background of charts in scalar card have black backgrounds. It is because of the threejs upgrades 420916a. Before we find a long-term solution, we can set the background opacity to zero as the temporary fix
before
after
