From fa62bb34b8dc19a71dbc90da54b9eabc42e85681 Mon Sep 17 00:00:00 2001 From: Jie-Wei Wu Date: Mon, 14 Feb 2022 16:19:58 -0800 Subject: [PATCH 1/3] manually set background to transparent --- .../widgets/line_chart_v2/lib/renderer/threejs_renderer.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tensorboard/webapp/widgets/line_chart_v2/lib/renderer/threejs_renderer.ts b/tensorboard/webapp/widgets/line_chart_v2/lib/renderer/threejs_renderer.ts index 7b9d18a21f..199803c806 100644 --- a/tensorboard/webapp/widgets/line_chart_v2/lib/renderer/threejs_renderer.ts +++ b/tensorboard/webapp/widgets/line_chart_v2/lib/renderer/threejs_renderer.ts @@ -287,6 +287,8 @@ export class ThreeRenderer implements ObjectRenderer { antialias: true, alpha: true, }); + // Workaround to fix background transparency is not set propoerly in threejs WebGLRenderer. + this.renderer.setClearColor(0x000000, 0); this.renderer.setPixelRatio(devicePixelRatio); } From eb93774bea106291c3b4eee00313fb9b2d42922c Mon Sep 17 00:00:00 2001 From: Jie-Wei Wu Date: Tue, 15 Feb 2022 09:54:48 -0800 Subject: [PATCH 2/3] move param out of context --- .../widgets/line_chart_v2/lib/renderer/threejs_renderer.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/tensorboard/webapp/widgets/line_chart_v2/lib/renderer/threejs_renderer.ts b/tensorboard/webapp/widgets/line_chart_v2/lib/renderer/threejs_renderer.ts index 199803c806..7b9d18a21f 100644 --- a/tensorboard/webapp/widgets/line_chart_v2/lib/renderer/threejs_renderer.ts +++ b/tensorboard/webapp/widgets/line_chart_v2/lib/renderer/threejs_renderer.ts @@ -287,8 +287,6 @@ export class ThreeRenderer implements ObjectRenderer { antialias: true, alpha: true, }); - // Workaround to fix background transparency is not set propoerly in threejs WebGLRenderer. - this.renderer.setClearColor(0x000000, 0); this.renderer.setPixelRatio(devicePixelRatio); } From dc1e546145d2bf61b76bf40b28eea9c1268ffab4 Mon Sep 17 00:00:00 2001 From: Jie-Wei Wu Date: Wed, 16 Feb 2022 08:45:47 -0800 Subject: [PATCH 3/3] remove provided context --- .../widgets/line_chart_v2/lib/renderer/threejs_renderer.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/tensorboard/webapp/widgets/line_chart_v2/lib/renderer/threejs_renderer.ts b/tensorboard/webapp/widgets/line_chart_v2/lib/renderer/threejs_renderer.ts index 7b9d18a21f..5a06283e7e 100644 --- a/tensorboard/webapp/widgets/line_chart_v2/lib/renderer/threejs_renderer.ts +++ b/tensorboard/webapp/widgets/line_chart_v2/lib/renderer/threejs_renderer.ts @@ -283,7 +283,6 @@ export class ThreeRenderer implements ObjectRenderer { this.renderer = new THREE.WebGLRenderer({ canvas: canvas as HTMLCanvasElement, - context: canvas.getContext('webgl2') as WebGLRenderingContext, antialias: true, alpha: true, });