Show histogram tooltips that bleed out of content box. #5631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japie1235813
approved these changes
Mar 28, 2022
bmd3k
changed the title
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
* Motivation for features / changes The small histogram tooltip can be cutoff by the top or right edges (Googlers, see b/226775031). * Technical description of changes A couple of ancestor elements of the tooltip element currently set `overflow: hidden`. We change these elements so that the effective value is 'overflow: visible'. This has the somewhat unintended side effect of exposing an additional ~1px height flat line just above the x axis (because the set of lines in the '.content' element ever so slightly overflow). This is probably ok since we'd prefer for the user to see all histogram lines. We should consider in the future tightening up the histogram rendering so that all the lines fit nicely into the '.content' element. (Googlers, see screenshot diffs in cl/437279846).
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
* Motivation for features / changes The small histogram tooltip can be cutoff by the top or right edges (Googlers, see b/226775031). * Technical description of changes A couple of ancestor elements of the tooltip element currently set `overflow: hidden`. We change these elements so that the effective value is 'overflow: visible'. This has the somewhat unintended side effect of exposing an additional ~1px height flat line just above the x axis (because the set of lines in the '.content' element ever so slightly overflow). This is probably ok since we'd prefer for the user to see all histogram lines. We should consider in the future tightening up the histogram rendering so that all the lines fit nicely into the '.content' element. (Googlers, see screenshot diffs in cl/437279846).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
The small histogram tooltip can be cutoff by the top or right edges (Googlers, see b/226775031).
Technical description of changes
A couple of ancestor elements of the tooltip element currently set
overflow: hidden. We change these elements so that the effective value is 'overflow: visible'.This has the somewhat unintended side effect of exposing an additional ~1px height flat line just above the x axis (because the set of lines in the '.content' element ever so slightly overflow). This is probably ok since we'd prefer for the user to see all histogram lines. We should consider in the future tightening up the histogram rendering so that all the lines fit nicely into the '.content' element. (Googlers, see screenshot diffs in cl/437279846).
Screenshots
Tooltip at top before:
Tooltip at top after:
Tooltip at right before:
Tooltip at right after: