Comment out inconsistent test in _keras_test.py
#6767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bileschi
approved these changes
Feb 20, 2024
rileyajones
changed the title
_keras_test.py_keras_test.py
|
I concur with this decision to comment out the test. The test appears to be checking on behavior that can not be guaranteed depending on the backing version of Keras. |
rileyajones
force-pushed
the
fix-keras-test
branch
from
2f0896b to
59e0fa4
Compare
bmd3k
added a commit
that referenced
this pull request
Mar 4, 2024
#6759 modified _keras_test.py to work with Keras 3 but it did not import correctly into the internal repository. It was therefore reverted in #6767. This changes the test to work both in the oss and internal repos. Googlers, see cl/612511563 for sample import results.
AnuarTB
pushed a commit
to AnuarTB/tensorboard
that referenced
this pull request
May 3, 2024
tensorflow#6759 modified _keras_test.py to work with Keras 3 but it did not import correctly into the internal repository. It was therefore reverted in tensorflow#6767. This changes the test to work both in the oss and internal repos. Googlers, see cl/612511563 for sample import results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
This test behaves differently internally and externally. The changes made in #6761 succeed in getting the test to pass externally, but it will then fail when imported Googlers see (cl/608667862).