Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggressively filter "non-cookbook" files before uploading to instances. #124

Merged
merged 2 commits into from
May 27, 2013

Conversation

fnichol
Copy link
Contributor

@fnichol fnichol commented May 24, 2013

In order to minimize the amount of extra files in a cookbook project
that must be uploaded to an instance, the prepared directory of
cookbooks is processed to eliminate "non-cookbook" files. The following
files are considered production cookbook files:

  • README.*
  • metadata.{json,rb}
  • attributes/**/*
  • definitions/**/*
  • files/**/*
  • libraries/**/*
  • providers/**/*
  • recipes/**/*
  • resources/**/*
  • templates/**/*

References #35

In order to minimize the amount of extra files in a cookbook project
that must be uploaded to an instance, the prepared directory of
cookbooks is processed to eliminate "non-cookbook" files. The following
files are considered production cookbook files:

* `README.*`
* `metadata.{json,rb}`
* `attributes/**/*`
* `definitions/**/*`
* `files/**/*`
* `libraries/**/*`
* `providers/**/*`
* `recipes/**/*`
* `resources/**/*`
* `templates/**/*`

References #35
@jtimberman
Copy link
Contributor

I don't think the readme is required.

@fnichol
Copy link
Contributor Author

fnichol commented May 25, 2013

I was wondering about the README, only if metadata.rb was IO.reading it in. Would chef-solo or chef-client care about evaluating metadata.rb?

@jtimberman
Copy link
Contributor

I believe that solo parses it in chef 11 but I'd have to look at the code.

fnichol added a commit that referenced this pull request May 27, 2013
Aggressively filter "non-cookbook" files before uploading to instances.
@fnichol fnichol merged commit 2733af0 into master May 27, 2013
@fnichol fnichol deleted the filter-cookbook-files-to-upload branch May 27, 2013 21:44
BrentOnRails pushed a commit to BrentOnRails/test-kitchen that referenced this pull request Jul 17, 2017
Fixing error where aws returns DNS name as empty string
@test-kitchen test-kitchen locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants