Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donloading in MP3 crashes the application #1188

Closed
TJW65 opened this issue Jul 1, 2023 · 12 comments · Fixed by #1235
Closed

Donloading in MP3 crashes the application #1188

TJW65 opened this issue Jul 1, 2023 · 12 comments · Fixed by #1235
Labels
awaiting-reply Awaiting reply cannot-reproduce Bug cannot be reproduced fix-available A fix to the issue is available in a new version

Comments

@TJW65
Copy link

TJW65 commented Jul 1, 2023

Hey,
after a while I've come to use the downloader plugin once more, only to find the whole application crashing when downloading anything in MP3.
I'm not completely certain - but I think to have seen it working under 1.20 already on my windows 11 machine. So theoretically nothing should have changed, or are plugins updated silently in the background, separately from the main application? My OS environment should also be pretty much unchanged, execept for some small cumulative Windows updates maybe.
Downloading in opus works flawlessly - and faster, without the conversion to MP3 - but I really like having my id3 data. Thank you for adding that btw.

Greetings
TJW65

@th-ch
Copy link
Owner

th-ch commented Jul 4, 2023

👋 Hey @TJW65, it seems to work fine on MacOS 🤔 Could you run it in dev mode and report the exception that happens?

@th-ch th-ch added cannot-reproduce Bug cannot be reproduced awaiting-reply Awaiting reply labels Jul 4, 2023
@TJW65
Copy link
Author

TJW65 commented Jul 5, 2023

Hey,
thanks for the reply.
Unfortunately, I don't quite know what to do with the commands you linked.
I'm not a developer - more used to the typical end user UI.

@bladehorton
Copy link

I can confirm that MP3 downloads also crash my application. (Running on Arch Linux, installed through the AUR)
Opus downloads work fine.
Developer mode does not make a difference.
It would appear that turning off Discord integration fixed the issue for me

@CMKCMK73
Copy link

Confirmed. this happens on macOS as well for me.

@Xabi08YT
Copy link

Confirmed, this happens to me on windows.

@Xabi08YT
Copy link

OPUS codec fixes the problem. If you want it in mp3, use FormatFactory to convert it or FFMPEG (maybe it should do the trick, i don't really know bcz I don,'t use it so much).

@Xabi08YT
Copy link

Nevermind, Formatfactory doesn't support opus.

@CheeseFort
Copy link

I can confirm that MP3 downloads also crash my application. (Running on Arch Linux, installed through the AUR) Opus downloads work fine. Developer mode does not make a difference. It would appear that turning off Discord integration fixed the issue for me

Confirmed. Windows 10 application crashes when downloading to mp3 only if the Discord plugin is enabled. The crash happens either when converting or sometimes when writing id3 tags.

@JellyBrick
Copy link
Collaborator

JellyBrick commented Sep 5, 2023

Are you experiencing these issues with this version as well?

If you don't trust this file, follow the below link and build it yourself.

https://github.com/organization/youtube-music-next/tree/feat/typescript

@CheeseFort
Copy link

Interesting, I installed JellyBrick's fork over the original. The application no longer crashes, however, some songs result in an error and fail when the application normally would have crashed. I then installed the original over JellyBrick's fork and now everything works as expected. 🤷‍♂️ 😕😵

@JellyBrick
Copy link
Collaborator

Interesting, I installed JellyBrick's fork over the original. The application no longer crashes, however, some songs result in an error and fail when the application normally would have crashed. I then installed the original over JellyBrick's fork and now everything works as expected. 🤷‍♂️ 😕😵

Could I get the link to the "some songs"?

@CheeseFort
Copy link

CheeseFort commented Sep 6, 2023

Here's one
From my experiments, which song worked and which didn't was random, but if a song downloaded once it would always download, and if it failed it would always fail.

Edit: another one, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-reply Awaiting reply cannot-reproduce Bug cannot be reproduced fix-available A fix to the issue is available in a new version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants