Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume range seems logarithmic, and a precise-volume bug #500

Closed
francislavoie opened this issue Nov 22, 2021 · 3 comments
Closed

Volume range seems logarithmic, and a precise-volume bug #500

francislavoie opened this issue Nov 22, 2021 · 3 comments

Comments

@francislavoie
Copy link

francislavoie commented Nov 22, 2021

Kinda strange, changing the volume anywhere between ~35-100% seems to do nothing, but the volume levels between 0-35% are basically the full range. So changing the volume from 100% to 50% does basically nothing.

This behaviour is very different from https://github.com/ytmdesktop/ytmdesktop which more gradually changes volume.


Didn't feel like making a separate issue for this, but the precise-volume plugin (which I enabled to see if it would make any difference to the volume range mentioned above -- it doesn't) has a problem with the "Set Custom Volume Steps" dialog window; it flickers into view for one frame, then automatically closes before I can interact with it. This is on Windows 10. Other dialog windows like the one from the shortcuts plugin opens up fine though. I was able to change the steps via the config.json file so it's not too big a deal for me.

Wild guess from looking at the code and comparing shortcuts to precise-volume, is it because there's no defined height?

@Araxeus
Copy link
Collaborator

Araxeus commented Nov 22, 2021

Didn't feel like making a separate issue for this, but the precise-volume plugin (which I enabled to see if it would make any difference to the volume range mentioned above -- it doesn't) has a problem with the "Set Custom Volume Steps" dialog window; it flickers into view for one frame, then automatically closes before I can interact with it. This is on Windows 10. Other dialog windows like the one from the shortcuts plugin opens up fine though. I was able to change the steps via the config.json file so it's not too big a deal for me.

Wild guess from looking at the code and comparing shortcuts to precise-volume, is it because there's no defined height?

Thank you for this report! this actually happened because of a bug in the custom-electron-prompt library which I fixed and updated that package to the new version in PR #476 commit abc1712

that bug happened because an external pr changed some code which made some function miss its argument - which was fixed in the library easily
Araxeus/custom-electron-prompt@dd5fc8e

@Araxeus
Copy link
Collaborator

Araxeus commented Nov 22, 2021

Kinda strange, changing the volume anywhere between ~35-100% seems to do nothing, but the volume levels between 0-35% are basically the full range. So changing the volume from 100% to 50% does basically nothing.

I can't actually reproduce this, it all works fine for me. but maybe you should try the new upcoming Exponential Volume plugin when it comes out after #488 is merged

I think that plugin might help with your problem 🙂

@francislavoie
Copy link
Author

Ah nice! Yeah, that new plugin looks like exactly what I was hoping for. Thanks 👍 I'll close this since it's already being tracked in that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants