Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "PH" value in database #125

Merged
merged 3 commits into from
Mar 20, 2018
Merged

Adding "PH" value in database #125

merged 3 commits into from
Mar 20, 2018

Conversation

nke69
Copy link
Contributor

@nke69 nke69 commented Mar 20, 2018

Hello Mr. Daygecko;)

I just made a request after a modification that I brought in my fork to store the values of the PH and also to display the graphs in the PH template.

I hope I have not forgotten anything;)
Reason why I let you check these "very small" additions ..

On my side, it works very well the display is perfect, but im not a developer .. I still have a doubt about the correct coding of my modification.
in attached file the overview of what this gives

Good to you.
nke69.
capture

Continued from #87

nke69 added 3 commits March 20, 2018 12:59
Add "PH" value to collect information into the database.
Continued from #87
Added "PH" value to display ph value in the graphics.
Continued from #87
Added the value "PH" for displaying graphs.
Continued from #87
@theyosh
Copy link
Owner

theyosh commented Mar 20, 2018

Damm... thanks. Totally forgotten.. I will change a bit of this code, but thanks again

@theyosh theyosh closed this Mar 20, 2018
@theyosh theyosh reopened this Mar 20, 2018
@theyosh theyosh merged commit 0b546a1 into theyosh:master Mar 20, 2018
theyosh added a commit that referenced this pull request Mar 20, 2018
@nke69
Copy link
Contributor Author

nke69 commented Mar 21, 2018

Hello,
glad to help you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants