fixup! fixup! fixup! POC: Can we remove usage of the timer actor?

thin-edge · Mar 7, 2024 · e37bc2e · e37bc2e
1 parent ea6a594
commit e37bc2e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/crates/extensions/c8y_firmware_manager/src/actor.rs b/crates/extensions/c8y_firmware_manager/src/actor.rs
@@ -74,7 +74,7 @@ impl Actor for FirmwareManagerActor {
     // This actor handles 2 kinds of messages from its peer actors:
     //
     // 1. MQTT messages from the MqttActor for firmware update requests from the cloud and firmware update responses from the child devices
-    // 3. RequestOutcome sent back by the background workers once the firmware request has been fully processed or failed
+    // 2. RequestOutcome sent back by the background workers once the firmware request has been fully processed or failed
     async fn run(mut self) -> Result<(), RuntimeError> {
         self.resend_operations_to_child_device().await?;
         // TODO: We need a dedicated actor to publish 500 later.
@@ -784,7 +784,7 @@ impl FirmwareManagerWorker {
                 }
                 Err(_elapsed) => {
                     // The child device failed to process the request within the time limit
-                    return Err(FirmwareManagementError::FromTimeout {
+                    return Err(FirmwareManagementError::ExceedTimeLimit {
                         child_id,
                         time_limit_sec: time_limit.as_secs(),
                         operation_id,

diff --git a/crates/extensions/c8y_firmware_manager/src/error.rs b/crates/extensions/c8y_firmware_manager/src/error.rs
@@ -51,7 +51,7 @@ pub enum FirmwareManagementError {
     },
 
     #[error("Child device {child_id} did not respond within the timeout interval of {time_limit_sec}sec. Operation ID={operation_id}")]
-    FromTimeout {
+    ExceedTimeLimit {
         child_id: String,
         time_limit_sec: u64,
         operation_id: String,