Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails at PostgreSQL on OS X Yosemite DP7 #286

Closed
gohanlon opened this issue Sep 5, 2014 · 7 comments
Closed

Fails at PostgreSQL on OS X Yosemite DP7 #286

gohanlon opened this issue Sep 5, 2014 · 7 comments

Comments

@gohanlon
Copy link
Contributor

gohanlon commented Sep 5, 2014

This appears to be an upstream issue in Homebrew, PostgreSQL, or even OS X: brew install postgresql fails on OS X Yosemite Developer Preview 7 (DP7).

As of Homebrew/legacy-homebrew@cd33c4b, installing Laptop on a clean OS X Yosemite DP 7 fails as follows:

$ bash <(curl -s https://raw.githubusercontent.com/thoughtbot/laptop/master/mac)
[snip]
==> Installing postgresql
==> Downloading http://ftp.postgresql.org/pub/source/v9.3.5/postgresql-9.3.5.tar.bz2
==> Patching
patching file contrib/uuid-ossp/uuid-ossp.c
==> ./configure --prefix=/usr/local/Cellar/postgresql/9.3.5_1 --datadir=/usr/local/Cellar/postgresql/9.3.5_1/share/postgresql --docdir=/usr/local/Cellar/postgresql/9.3.5_1/share/doc/postgresql --enable-thread-safety --with-bonjour --with-gssapi --with-ldap --with-openssl --with-pam --with-libxml --with-libxslt --with-perl --with-tcl --with-ossp-uuid
checking tcl.h presence... yes
checking for tcl.h... yes
checking for perl.h... yes
checking for libperl... no
configure: error: libperl library is required for Perl

READ THIS: https://github.com/Homebrew/homebrew/wiki/troubleshooting

failed

There is a mega-issue that tracks Homebrew formula status on OS X Yosemite: Homebrew/legacy-homebrew#29988. The issue states that brew install postgresql was broken but now works as of OS X Yosemite DP4. I added a comment to the mega-issue with the detailed failure information from my experience on clean DP7.

@sikachu
Copy link
Contributor

sikachu commented Sep 7, 2014

I can confirm this issue. Seems like Perl is definitely missing from DP7, as people are having problem compiling weechat as well in Homebrew/legacy-homebrew#32146.

Maybe we should just add --no-perl. I did brew reinstall postgresql --no-perl and it works.

@croaky
Copy link
Contributor

croaky commented Sep 8, 2014

--no-perl seems fine with me. For a long time, we had --no-python for similar reasons and lack of explicit need.

On Sep 7, 2014, at 3:03 PM, Prem Sichanugrist [email protected] wrote:

I can confirm this issue. Seems like Perl is definitely missing from DP7, as people are having problem compiling weechat as well in Homebrew/legacy-homebrew#32146.

Maybe we should just add --no-perl. I did brew reinstall postgresql --no-perl and it works.


Reply to this email directly or view it on GitHub.

@gohanlon
Copy link
Contributor Author

gohanlon commented Sep 8, 2014

This looks like a major issue when building with Perl and possibly many other Apple-supplied libs on DP7. Several brews are affected, including the following two Laptop brews that fail with linker errors:

  • brew install postgresql fails to link with libperl; workaround: brew install postgresql --no-perl
  • brew install vim fails to link with ncurses; no workaround explored

Note: It's a significant leap to assume that two linker errors have the same root cause, but it's at least somewhat less of a leap in this case as these errors where introduced at close to the same time.

In addition, Qt fails to compile (a failure that's unrelated to the above linker errors):

For PostgreSQL, my team doesn't need Perl support, so --no-perl is fine for us. If OS X Yosemite were final I think we'd be compelled to add the --no-perl workaround to Laptop rather than waiting for upstream fixes.

But, there's a bigger issue: This workaround for PostgreSQL isn't sufficient to make Laptop run successfully on OS X Yosemite DP7. We'd also need workarounds for Vim and Qt. Those workarounds may not be as trivial, and all the workarounds ought to be reverted as upstream fixes become available.

Since these issues apply to pre-release software (that Laptop doesn't claim to support), my inclination is to wait for or contribute to upstream fixes. An upstream fix for Qt is already being worked on. Apple may have acknowledged the bug affecting PostgreSQL and Vim, and a fix is anticipated soon in DP8 (assuming the errors are related).

@croaky For the OS X Yosemite DPs, do you think it's okay track Laptop problems but wait for upstream fixes rather than applying Laptop workarounds?

In any case, I'll check Laptop for OS X 10.10 Yosemite DP8 when it comes out (probably in a week or so).

croaky pushed a commit that referenced this issue Sep 30, 2014
A class of bugs are possible similar to why we had
`--no-python` for Postgres previously.

#286
@croaky
Copy link
Contributor

croaky commented Sep 30, 2014

Since these issues apply to pre-release software (that Laptop doesn't claim to support), my inclination is to wait for or contribute to upstream fixes.

That is my preference as well for pre-releases. We can test and potentially put in fixes but for these particular ones, it looks like the Homebrew issues are now closed and DP8 is out.

I think we can still add the --no-perl flag to Postgres (might speed things up anyway?), though: #293

I'm going to close this, but if I've misread those Homebrew threads or folks feel differently, please feel free to re-open.

@croaky croaky closed this as completed Sep 30, 2014
@gohanlon
Copy link
Contributor Author

I actually did test this on DP8, but ran into another problem that I think had to do with the Apple CLI Tools package installed by Homebrew not yet having been updated by Apple — I think they were the Xcode 6.0 CLI Tools when DP8 needed Xcode 6.1 CLI Tools, but I didn't pursue it long enough to say so definitively.

In any case GM Candidate 1.0 is out now and I updated my VM to it over lunch. I'm testing Laptop now from it's master branch (which at the moment doesn't disable Perl; it's without #293).

@gohanlon
Copy link
Contributor Author

gohanlon commented Oct 1, 2014

Laptop successfully installs on OS X Yosemite GM Candidate 1.0 — see the laptop.log. Note that the install succeeded without disabling Perl — adding --no-perl is not needed.

@croaky
Copy link
Contributor

croaky commented Oct 1, 2014

Thanks, @gohanlon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants