Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add installation argument to push command #83

Merged
merged 1 commit into from
Dec 22, 2021
Merged

feat: add installation argument to push command #83

merged 1 commit into from
Dec 22, 2021

Conversation

tget4
Copy link
Contributor

@tget4 tget4 commented Dec 20, 2021

This adds the ability to pass InstallationID into the push command to persist the app

@tget4 tget4 changed the title feat: add installation argument feat: add installation argument to push command Dec 20, 2021
betterengineering
betterengineering approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@betterengineering betterengineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks so much for putting this together. We should probably create a special section of the README for installation ID given the current confusion and remove it from the example command. I can follow up with an additional change.

@betterengineering betterengineering merged commit 3588131 into tidbyt:main Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betterengineering betterengineering betterengineering approved these changes

@matslina matslina Awaiting requested review from matslina

@rohansingh rohansingh Awaiting requested review from rohansingh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tget4 @betterengineering