From 36db3c745f89c12d991886d79c57e6e677b1ba72 Mon Sep 17 00:00:00 2001
From: LLThomas <zs033@qq.com>
Date: Tue, 7 Jun 2022 14:28:30 +0800
Subject: [PATCH] kv: migrate test framework to testify (#5111)

ref tikv/pd#4813

Signed-off-by: LLThomas <zs033@qq.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
---
 server/storage/kv/kv_test.go | 69 +++++++++++++++++-------------------
 1 file changed, 32 insertions(+), 37 deletions(-)

diff --git a/server/storage/kv/kv_test.go b/server/storage/kv/kv_test.go
index 51c90e8a1d1..88bac9b279f 100644
--- a/server/storage/kv/kv_test.go
+++ b/server/storage/kv/kv_test.go
@@ -23,75 +23,70 @@ import (
 	"strconv"
 	"testing"
 
-	. "github.com/pingcap/check"
+	"github.com/stretchr/testify/require"
 	"github.com/tikv/pd/pkg/tempurl"
 	"go.etcd.io/etcd/clientv3"
 	"go.etcd.io/etcd/embed"
 )
 
-func TestKV(t *testing.T) {
-	TestingT(t)
-}
-
-type testKVSuite struct{}
-
-var _ = Suite(&testKVSuite{})
-
-func (s *testKVSuite) TestEtcd(c *C) {
+func TestEtcd(t *testing.T) {
+	re := require.New(t)
 	cfg := newTestSingleConfig()
 	defer cleanConfig(cfg)
 	etcd, err := embed.StartEtcd(cfg)
-	c.Assert(err, IsNil)
+	re.NoError(err)
 	defer etcd.Close()
 
 	ep := cfg.LCUrls[0].String()
 	client, err := clientv3.New(clientv3.Config{
 		Endpoints: []string{ep},
 	})
-	c.Assert(err, IsNil)
+	re.NoError(err)
 	rootPath := path.Join("/pd", strconv.FormatUint(100, 10))
 
 	kv := NewEtcdKVBase(client, rootPath)
-	s.testReadWrite(c, kv)
-	s.testRange(c, kv)
+	testReadWrite(re, kv)
+	testRange(re, kv)
 }
 
-func (s *testKVSuite) TestLevelDB(c *C) {
+func TestLevelDB(t *testing.T) {
+	re := require.New(t)
 	dir, err := os.MkdirTemp("/tmp", "leveldb_kv")
-	c.Assert(err, IsNil)
+	re.NoError(err)
 	defer os.RemoveAll(dir)
 	kv, err := NewLevelDBKV(dir)
-	c.Assert(err, IsNil)
+	re.NoError(err)
 
-	s.testReadWrite(c, kv)
-	s.testRange(c, kv)
+	testReadWrite(re, kv)
+	testRange(re, kv)
 }
 
-func (s *testKVSuite) TestMemKV(c *C) {
+func TestMemKV(t *testing.T) {
+	re := require.New(t)
 	kv := NewMemoryKV()
-	s.testReadWrite(c, kv)
-	s.testRange(c, kv)
+	testReadWrite(re, kv)
+	testRange(re, kv)
 }
 
-func (s *testKVSuite) testReadWrite(c *C, kv Base) {
+func testReadWrite(re *require.Assertions, kv Base) {
 	v, err := kv.Load("key")
-	c.Assert(err, IsNil)
-	c.Assert(v, Equals, "")
+	re.NoError(err)
+	re.Equal("", v)
 	err = kv.Save("key", "value")
-	c.Assert(err, IsNil)
+	re.NoError(err)
 	v, err = kv.Load("key")
-	c.Assert(err, IsNil)
-	c.Assert(v, Equals, "value")
+	re.NoError(err)
+	re.Equal("value", v)
 	err = kv.Remove("key")
-	c.Assert(err, IsNil)
+	re.NoError(err)
 	v, err = kv.Load("key")
-	c.Assert(err, IsNil)
-	c.Assert(v, Equals, "")
+	re.NoError(err)
+	re.Equal("", v)
 	err = kv.Remove("key")
-	c.Assert(err, IsNil)
+	re.NoError(err)
 }
 
-func (s *testKVSuite) testRange(c *C, kv Base) {
+func testRange(re *require.Assertions, kv Base) {
 	keys := []string{
 		"test-a", "test-a/a", "test-a/ab",
 		"test", "test/a", "test/ab",
@@ -99,7 +94,7 @@ func (s *testKVSuite) testRange(c *C, kv Base) {
 	}
 	for _, k := range keys {
 		err := kv.Save(k, k)
-		c.Assert(err, IsNil)
+		re.NoError(err)
 	}
 	sortedKeys := append(keys[:0:0], keys...)
 	sort.Strings(sortedKeys)
@@ -120,9 +115,9 @@ func (s *testKVSuite) testRange(c *C, kv Base) {
 
 	for _, tc := range testCases {
 		ks, vs, err := kv.LoadRange(tc.start, tc.end, tc.limit)
-		c.Assert(err, IsNil)
-		c.Assert(ks, DeepEquals, tc.expect)
-		c.Assert(vs, DeepEquals, tc.expect)
+		re.NoError(err)
+		re.Equal(tc.expect, ks)
+		re.Equal(tc.expect, vs)
 	}
 }