Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI change issues #340

Open
temirlan-remington opened this issue Mar 27, 2024 · 11 comments
Open

New UI change issues #340

temirlan-remington opened this issue Mar 27, 2024 · 11 comments
Labels

Comments

@temirlan-remington
Copy link

Describe the bug
When navigating to an account with the new UI change.

The switch role screen does not pre-fill the values.
Screenshot 2024-03-27 at 11 38 07

To Reproduce
Steps to reproduce the behaviour:

  1. Configure an account with role_arn value that will contain ! at the end
  2. Click on the plugin to switch account
  3. choose account from step 1
  4. You will be redirected to the Switch Role Page with All values empty (this is the issue)

Expected behavior
When reproducing the issue the expected behaviour of step 4 should be:
Switch role should be pre-filled with:

  • Account ID = account ID from the part of the role_arn
  • IAM role name = role name from role_arn part
  • Display Name = profile name
  • Display color = color value if set

Screenshots
Screenshot in description

Additional context

We use role_arn parameter and for Elevated account we add ! at the end so it will rediret to switch account page and someone has to remove the ! and switch the role (Just to avoid accidental use of elevated account)

Sample config

[profile Production]
role_arn = arn:aws:iam::XXXXXXXXXXXXX:role/AdminRole!
source_profile = identity-account

@olleja-b
Copy link

Having exactly the same issues.

@yavuzb
Copy link

yavuzb commented Mar 27, 2024

Looks like the AWS UI now presents a completely empty form, instead of giving the user the chance to correct the error in the role name.

@tilfin
Copy link
Member

tilfin commented Mar 27, 2024

AWS Extend Switch Roles is not involved in this Switch Role page. It merely emulates the action of clicking on the switch role history list on each AWS Management Console page. Therefore, it is up to AWS to fill in the parameters in the form when switching role is failed.

@tilfin tilfin added the wontfix label Mar 27, 2024
@mehakkhanna02
Copy link

Having exactly the same issues.

1 similar comment
@Hiren-marakana
Copy link

Having exactly the same issues.

@temirlan-remington
Copy link
Author

@tilfin, would be the case that the plugin is not passing the right values?

Screenshot 2024-03-28 at 09 52 22

@temirlan-remington
Copy link
Author

@tilfin when I try to fill the role values using URL https://signin.aws.amazon.com/switchrole?roleName=Admin!&account=123456797045

It keeps the values in the switch role page if they are invalid and not reset

Screenshot 2024-03-28 at 10 21 32

@tilfin
Copy link
Member

tilfin commented Mar 28, 2024

@temirlan-remington When jumping from the AWS Management Console page, it is a POST request with a form body, which works differently from opening the URL with query parameters in a browser. If the POST request is invalid, the redirect will take you to the Switch Role form page. The process is handled by AWS, so AWS Extend Switch Roles cannot be involved.

@tilfin
Copy link
Member

tilfin commented Apr 2, 2024

I have confirmed that the form fields are also not filled when the switch fails by clicking on the link in the Role history in the AWS Management Console page.

Please request AWS to revert the switch failure behaviour.

@grimm26
Copy link

grimm26 commented Apr 22, 2024

the weird thing is that it still works in one of my browsers

@grimm26
Copy link

grimm26 commented Apr 22, 2024

I found that I only hit this problem when using a web proxy. If you are affected and can try without a proxy, see if it suddenly starts working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants