Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: merging MSBuild project tools into OmniSharp / C# for VS Code #19

Closed
tintoy opened this issue Oct 8, 2017 · 2 comments
Closed

Comments

@tintoy
Copy link
Owner

tintoy commented Oct 8, 2017

As briefly discussed with @DustinCampbell in dotnet/vscode-csharp#1156 and dotnet/vscode-csharp#1780.

If it's practical to do so, my preference would be for merging (over time) all of the extension's functionality into OmniSharp and deprecating the original extension (as opposed to keeping both extensions around which would, IMHO, be a poorer experience for users since there are bound to be conflicts when they compete to provide intellisense for the same file).

A quick architectural overview is available here. Most of the components are pretty modular so it should be possible to bring over only the bits that constitute the actual MSBuild language service (i.e. understanding what a given location in the .xxproj file actually means, either at the XML or MSBuild level). @DustinCampbell if you have a spare couple of moments, would you mind looking over the architectural overview to see if there's anything in there that looks immediately incompatible with how you know OmniSharp works? It's all targeting netstandard2.0 so should build fine against net461 / mono (which is what I assume OmniSharp builds against).

Alternatively, if the idea is simply to use the MSBuild language service as-is from the "C# for VS Code" extension that's even easier from my perspective :)

@tintoy tintoy changed the title Discussion: merging MSBuild project tools into OmniSharp Discussion: merging MSBuild project tools into OmniSharp / C# for VS Code Oct 8, 2017
@tintoy
Copy link
Owner Author

tintoy commented Oct 15, 2017

Bump, bump - @DustinCampbell have you had time to look into this yet? No rush, BTW :)

@tintoy
Copy link
Owner Author

tintoy commented Dec 17, 2017

Following other discussions with @david-driscoll I'm going to close this in favour of eventual plans to create a meta-package that potentially includes OmniSharp, Cake, and this extension (among others).

@tintoy tintoy closed this as completed Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant