Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial skeleton of the cookbook in mdbook format #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eminence
Copy link

@eminence eminence commented Oct 9, 2018

This creates an initial skeleton of the cookbook in mdbook format (the same format used by the rust cookbook).

The only content here is a copy of cookbook.md, but split up into multiple files. Hopefully this layout matches what you had in mind for the cookbook.

Preview of the rendered book


And then build it:

mdbook build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer mdbook serve and instructions with opening browser.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. How does it look now?

@rylev
Copy link
Contributor

rylev commented Oct 9, 2018

What are your thoughts on the advantages of having this as a separate book vs just having it as a new section in the existing guides?

@eminence
Copy link
Author

eminence commented Oct 9, 2018

This comment which references the rust cookbook made me think that an mdBook was the target format. But if that's not the case, then we can simply drop this PR. On the other hand, if we want mdBook for everything (not just the cookbook), then I can easily modify the structure to bring everything under the mdBook structure.

@AndyGauge
Copy link
Contributor

mdbook provides links to run in the browser, expand hidden lines, and is backed by rust-skeptic. It looks like your ci is integrated with tests, but I'm not sure how convenient they are running locally.

@carllerche
Copy link
Member

Ah, I was only referencing the rough structure (one page per category and many examples per page).

If mdBook can be made to integrate into the Tokio website's layout and CSS (https://tokio.rs), then I would be fine wity replacing the docs section entirely with mdBook.

My primary goal is to maintain a cohesive website feel.

@carllerche
Copy link
Member

That said, the sketch looks good at a glance 👍

@carllerche
Copy link
Member

@AndyGauge @eminence if you want, someone can open an issue here to discuss mdBook for the website.

@eminence
Copy link
Author

eminence commented Oct 9, 2018

let me take a stab at bringing in the tokio website style into this book skeleton to see how that looks. then we can see how to move forward from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants