Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature "full" does not enable feature "test-util" #3395

Closed
wqfish opened this issue Jan 8, 2021 · 1 comment
Closed

Feature "full" does not enable feature "test-util" #3395

wqfish opened this issue Jan 8, 2021 · 1 comment
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. T-docs Topic: documentation

Comments

@wqfish
Copy link
Contributor

wqfish commented Jan 8, 2021

The document (https://docs.rs/tokio/1.0.1/tokio/index.html#feature-flags) says

full: Enables all Tokio public API features listed below.

But the test-util feature doesn't seem to be enabled with full. Probably either include the test-util feature with full, or clarify this in the document?

@wqfish wqfish added A-tokio Area: The main tokio crate C-bug Category: This is a bug. labels Jan 8, 2021
@Darksonn Darksonn added E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. T-docs Topic: documentation labels Jan 8, 2021
@Darksonn
Copy link
Contributor

Darksonn commented Jan 8, 2021

I've updated this as a doc issue and help-wanted in case anyone wants to update the doc. It shouldn't be enabled in full, since you should mainly be using it in tests.

@Darksonn Darksonn closed this as completed Jan 9, 2021
@Darksonn Darksonn removed E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. labels Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. T-docs Topic: documentation
Projects
None yet
Development

No branches or pull requests

2 participants