Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thanks #1

Open
jhr007 opened this issue Mar 19, 2018 · 1 comment
Open

Thanks #1

jhr007 opened this issue Mar 19, 2018 · 1 comment

Comments

@jhr007
Copy link

jhr007 commented Mar 19, 2018

FWIW I hope these aren't still live 😄

crypto-dca/config/.env

Line 9 in 7af177d

GITHUB_CLIENT_SECRET=3f3c6734bca69d7eafd06496b0431dbaf8a79f4e

Thanks for the write up. Came for the "graphql scaffold", came back for the docker dev/prod examples.
👍
@tomlagier
Copy link
Owner

Good catch, thanks! 😨

Appreciate the look-over. Moving forward, I don't think I'm going to do the frontend dev in a docker container anymore. I'm having too many performance issues, and needing to maintain separate containers for dev, test, and debug feels very inefficient.

I'm definitely going to keep doing it for prod, and might still do it for the API - it's a lot faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhr007 @tomlagier