git-pull fork #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue discovered accidentally in daizutabi#22 where a numpy docstring attribute without a description leads to IndexError of an empty line.
tony
added a commit
to vcs-python/libvcs
that referenced
this pull request
Aug 2, 2020
Handle parsing empty line
Without a trailing slash, CDNs like CloudFront will not be treated as a directory (depending on lambda@edge / workers config)
poetry is failing to handle locking for this:
mkapi = {git = "https://github.com/tony/mkapi", rev = "git-pull", extras = ["docs"], python = ">=3.7"}
In python 2.7 with poetry 1.0.10, it fails with:
/home/runner/.poetry/lib/poetry/_vendor/py2.7/subprocess32.py:149: RuntimeWarning: The _posixsubprocess module is not being used. Child process reliability may suffer if your program uses threads.
"program uses threads.", RuntimeWarning)
Installing dependencies from lock file
[RuntimeError]
Unable to retrieve the package version for /tmp/pypoetry-git-mkap8a5bZB
\#\#[error]Process completed with exit code 1.
See also:
- python-poetry/poetry#2391
- python-poetry/poetry#2176
…d base class
```python
class RepoLoggingAdapter(logging.LoggerAdapter):
"""Adapter for adding Repo related content to logger.
- [`RepoLoggingAdapter.bin_name`](RepoLoggingAdapter.bin_name) -> ``repo_vcs``
- [`RepoLoggingAdapter.name`](RepoLoggingAdapter.name) -> ``repo_name``
"""
```
See also:
- daizutabi#27
- Possibly related to daizutabi#26
tony
added a commit
to vcs-python/libvcs
that referenced
this pull request
Aug 6, 2020
tony
added a commit
to vcs-python/libvcs
that referenced
this pull request
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to see the diff / changes in the fork
Includes:
Fix for links on CDNs to append slash in directories
Handle parsing empty line daizutabi/mkapi#23 Fix for exception caused by numpy attributes without styling at end of docstring
Typo daizutabi/mkapi#24 Typo
Fix crash when parsing / splitting property, or using stdlib base clase daizutabi/mkapi#27 Crash with property
Note: after it gives this: