Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "cancel" action in modals #1576

Closed
2 tasks
szymonlesisz opened this issue Apr 16, 2020 · 3 comments · Fixed by #5363
Closed
2 tasks

Implement "cancel" action in modals #1576

szymonlesisz opened this issue Apr 16, 2020 · 3 comments · Fixed by #5363
Assignees
@dahaca
Labels
bug Something isn't working as expected connect Connect API related (ie. fee calculation) feature Product related issue visible for end user

Comments

@szymonlesisz
Copy link
Contributor

new trezord (2.0.29?) will allow us to "cancel" actions on display (like address validation, confirmation, etc..)

  • Implement cancel action in modals (trezor-connect)
  • Add new bridge to desktop build

Product:
Decide how to deal with older bridge (it will not work)
@szymonlesisz szymonlesisz added bug Something isn't working as expected feature Product related issue visible for end user labels Apr 16, 2020
@szymonlesisz szymonlesisz mentioned this issue Apr 16, 2020
Closed
@matejzak matejzak added this to the 1Q2020 milestone Apr 17, 2020
@matejzak matejzak self-assigned this Apr 17, 2020
@matejzak matejzak modified the milestones: 1Q2020, 2Q2020 Apr 24, 2020
@matejzak matejzak removed this from the 3Q2020 milestone Oct 23, 2020
@matejzak
Copy link

@szymonlesisz is this still relevant?

@szymonlesisz
Copy link
Contributor Author

yes it should be possible now, like in "send" modal

@matejzak matejzak added the MEDIUM label Sep 3, 2021
@matejzak matejzak mentioned this issue Sep 14, 2021
Closed
@hynek-jina hynek-jina added the connect Connect API related (ie. fee calculation) label Mar 7, 2022
@hynek-jina hynek-jina assigned sime and unassigned matejzak Mar 7, 2022
@dahaca dahaca assigned dahaca and unassigned sime Apr 7, 2022
@dahaca
Copy link
Contributor

dahaca commented Apr 7, 2022

Design of the abort button from Ondra:

image

@hynek-jina hynek-jina moved this to 🎯 To do in Suite Desktop Apr 8, 2022
@dahaca dahaca mentioned this issue May 10, 2022
Merged
@hynek-jina hynek-jina moved this from 🎯 To do to 🔎 Needs review in Suite Desktop May 17, 2022
Repository owner moved this from 🔎 Needs review to 🤝 Needs QA in Suite Desktop May 25, 2022
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dahaca dahaca

Labels
bug Something isn't working as expected connect Connect API related (ie. fee calculation) feature Product related issue visible for end user
Projects
Suite Desktop
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: device modal updates trezor/trezor-suite
5 participants
@sime @szymonlesisz @hynek-jina @matejzak @dahaca