Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle signals for clean exit #31

Closed
leeclemens opened this issue May 16, 2023 · 1 comment
Closed

Handle signals for clean exit #31

leeclemens opened this issue May 16, 2023 · 1 comment

Comments

@leeclemens
Copy link
Contributor

SIGINT and SIGTERM do not seem to cause crunch to exit cleanly. It would be nice to have a way to exit properly.

Example from running in podman

WARN[0010] StopSignal SIGTERM failed to stop container containercrunch in 10 seconds, resorting to SIGKILL
@leeclemens
Copy link
Contributor Author

leeclemens commented May 31, 2023 •
edited
Loading

I'm new to rust in general and had not realized they do not support signal handling in the standard library. It seems they are waiting for 3rd party crates to help formulate an API (rust-lang/rfcs#1368 (comment)).

I'm testing out using tokio, although it does have a larger code base (but is also far more popular/used).

@leeclemens leeclemens closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leeclemens