Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove try_get_ methods from ByteBuf #111

Open
rukai opened this issue Feb 4, 2025 · 0 comments
Open

Remove try_get_ methods from ByteBuf #111

rukai opened this issue Feb 4, 2025 · 0 comments

Comments

@rukai
Copy link
Collaborator

rukai commented Feb 4, 2025

Remove the try_get_* methods here

kafka-protocol-rs/src/protocol/buf.rs

Line 57 in 10bacb2

fn try_get_u8(&mut self) -> Result<u8, NotEnoughBytesError> {

The upstream Buf trait now implements these methods so implementing them again is confusing for both developers and users of kafka-protocol crate.

First give the bytes team a week to decide if they are keeping or reverting the changes, see: tokio-rs/bytes#767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rukai