Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

span masking #12

Open
jianglong-he-Infrrd opened this issue Mar 2, 2023 · 1 comment
Open

span masking #12

jianglong-he-Infrrd opened this issue Mar 2, 2023 · 1 comment

Comments

@jianglong-he-Infrrd
Copy link

Hi, in apply_mask_on_token_bbox method it looks like you are masking only first token of the span then loose the bbox of whole span. Why not masking all tokens in the span?
@uakarsh
Copy link
Owner

uakarsh commented Mar 2, 2023

Yep that is right, I should have done that earlier, but I was not knowing that earlier. Am just reflecting that from sometime back, so would do that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uakarsh @jianglong-he-Infrrd