Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pop_artmwppth/eegplot fails to update marker removal on review #203

Open
mjowens opened this issue Feb 18, 2025 · 3 comments
Open

pop_artmwppth/eegplot fails to update marker removal on review #203

mjowens opened this issue Feb 18, 2025 · 3 comments

Comments

@mjowens
Copy link

mjowens commented Feb 18, 2025

After running pop_artmwppth* any epoch with an artifact cannot be removed after it calls pop_eegplot for review. Typically, in the eegplot clicking "update markers" will result in a pop message that warns you about marking epochs when removing or adding epochs. Now it only shows the warning message when adding epochs and will not register (or allow) any change to remove highlighted epochs.

In addition to using the gui have tried to the following.

  1. using the legacy eegplot
  2. running EEG = eegcheckset( EEG) after pop_artmwppth
  3. running eeglab redraw pop_artmwppth, and either: saving over previous set and creating a new one
  4. adjusting the flag codes

*I have observed this issue using in-line code (below) and the GUI interface.
      EEG = pop_artmwppth( EEG , 'Channel', [1:29], 'Flag', [1 8], 'Review', 'on', 'Threshold', 100, 'Windowsize', 200, 'Windowstep', 100 );

Versions
MATLAB R2024a
ERPLAB 11.03

@davidg622
Copy link
Collaborator

Hello,

Just to provide clarification on the issue you bring up:
After running pop_artmwppth, a plot will open, allowing you to mark/unmark epochs for rejection. After pressing "Update Markers", the following popup will appear:

Image

Is this the same warning message that you are referring to?

David

@mjowens
Copy link
Author

mjowens commented Feb 20, 2025

Hello,

Just to provide clarification on the issue you bring up: After running pop_artmwppth, a plot will open, allowing you to mark/unmark epochs for rejection. After pressing "Update Markers", the following popup will appear:

Image

Is this the same warning message that you are referring to?

David

Yes, a plot will open and allow me to mark/unmark epochs for rejection. That is the warning message. However, that pop-up will appear only when adding marks to epoched data. When trying to remove marked epochs no pop-up will appear and no changes will be made.

@davidg622
Copy link
Collaborator

Hello,

I attempted to replicate your issue with my own data, but found that in unmarking epochs, my data was updated as expected. There are two things we might try now:

  1. What version of EEGLAB are you using? The most recent version is v2024.2. If it's not up to date, that might be causing the issue.
  2. You could email me a sample of your data at my [email protected], and I can try to replicate this issue on your data.

Best,

David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants