fix: remove empty array elements to reduce scope transfer size #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Volker Buzek <[email protected]>
Siolto
changed the title
|
Wow, thank you for that fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After going deep down the rabbit hole, it turns out that the binding context object in already a small FE app is humongously huge. Thus, when (in Node.js) a
getBindingContext()is called on a located control for subsequent asserts on the binding object, the binding context object transferred between the browser- and the Node.js-scope is > 100 MB (!), causing serialisation operations fail.This PR "cleans" the located controls internal object properties already in browser-scope by removing all private properities (starting with
_) andnullArray members.The "cleaned" object is then only a fraction of its original size, (hopefully) making everyone more happy.
Closes #557