-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): new auth with cert service #649
Conversation
fd67a0b
to
edf2d82
Compare
b12cc11
to
19496ca
Compare
19496ca
to
4841e94
Compare
4841e94
to
09deac8
Compare
09deac8
to
4aff5ae
Compare
4aff5ae
to
d7baf55
Compare
e0ed1c0
to
d7baf55
Compare
This automation done in |
I haven't seen any example of it. Can you show me a demo or documentation ? |
@marianfoo sorry I was a bit to quick to judge here. It is currently not as easy to do it with WebDriver. |
@christian-bromann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally got to this - and it's GOOD
this will hopefully remove the blocker for using wdi5 with apps deployed on BTP with standard SAP Client ID authentication
// browserName: "..." | ||
"wdi5:authentication": { | ||
provider: "Certificate", | ||
certificateOrigin: "https://accounts.sap.com", // this should always be accounts.sap.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it should always be accounts.sap.com
, we could also move it away from user-facing ... but that's optional, so nothing to act on for now
|
||
constructor(options: CertAuthenticatorType, browserInstanceName, baseUrl: string) { | ||
super(browserInstanceName) | ||
this.origin = options.certificateOrigin || "https://accounts.sap.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
first PoC to authenticate with a SAP Passport Certificate to BTP using playwright and abstraction package
playwright-client-certificate-login
currently, to make this work, put pfx file to folder
ui5-ts-app
and rename it to sap.pfx and put your passphrase to in the CertAuthenticator.ts and runnpm run authentication:btp
.This is just a PoC, needs better testing cases and proper config handling in the
CertAuthenticator.ts
.Still work to do but it works locally, should also work on pipelines