fix conversion issues when converting from formats with alpha channel(png,webp) to jpeg format #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… like png,webp to jpeg format
|
Thanks for the PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #32
Converting from png/webp to jpeg creates issues as jpeg doesn't support alpha channel. Simply discarding alpha channel by 'Image.convert()' function of Pillow also creates issues with png/webp images having transparent background.
Added a fix where png/webp images are put on a new blank image of same size. This fills the transparent background and then image can be converted to jpeg.
I set the fill color to be black but perhaps this can be set by user through an argument to 'ResizedImageField'.