Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this library (SASS source) extensible. #156

Merged
merged 2 commits into from
Mar 11, 2016
Merged

Conversation

bunomonteiro
Copy link
Contributor

Q: What this PR fixes?
A: Allows add filter to an existing CSSgram filter (only using SASS)

Q: Why?
A: CSS3 filter property does not allow inheritance, you cannot 'add' new filters keeping the existing filters

Before:

figure {
  @extend %aden;
  &:hover{
    filter: blur(2px); // overrides Aden filter, now has only blur filter
  }
}

Now:

figure {
  @extend %aden; // or @include aden;
  &:hover{
    @include aden(blur(2px) /*...*/); // Aden filter still works, but now blur filter was 'added'
  }
}

PS: Now comments are compatible with SassDoc.

😄

- Now comments are compatible with SassDoc.
@bunomonteiro bunomonteiro changed the title Make this library (SASS source) extensible. 😄 Make this library (SASS source) extensible. Feb 7, 2016
@una
Copy link
Owner

una commented Feb 21, 2016

@bunomonteiro, this is a great point -- do you mind updating the docs as a part of this PR with the updated usage?

@bunomonteiro
Copy link
Contributor Author

Of course! Why not? 😉

@una
Copy link
Owner

una commented Mar 11, 2016

Sorry for the wait on this -- I've been thinking it through since this is a major addition! I do like it a lot and it's backwards compatible with an additional consumption model I definitely agree is important to have.

Thank you for your careful consideration and documentation! ✨ This is great!

una added a commit that referenced this pull request Mar 11, 2016
Make this library (SASS source) extensible.
@una una merged commit d089ad4 into una:master Mar 11, 2016
@bunomonteiro
Copy link
Contributor Author

uhuu!

No need to apologize, it did not take much. It took the time needed to do a good job. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants