Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve temperature unit handling for generic thermostat climate entity #28

Open
zehnm opened this issue Oct 12, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@zehnm
Copy link
Contributor

zehnm commented Oct 12, 2023

The climate entity in Home Assistant defines the temperature_unit for °C or °F. According to the documentation this should be a required property.
In Remote Two, the correct unit handling is prepared, but not yet verified (#10).
However, the generic thermostat does not support custom temperature units, and simply takes the configured HA system unit:

This can be verified with the Remote Two Core-simulator and the prepared thermostat entities.

The temperature unit works as long as the HA unit system matches the Remote Two localization. For mixed environments or special use cases, this doesn't work correctly.

Proposed enhancements:

  • To use the same unit system, the HA configuration needs to be read and set into all climate entities, which don't specify a temperature_unit option.
    This will force the temperature values of all entities to the configured HA unit system and display the same value as in the HA dashboard. Switching the Remote Two units, won't change the temperature label anymore.
  • Add a configuration option in the HA integration setup to choose the temperature unit behaviour:
    • Use Remote Two setting if entity is missing temperature_unit (current behaviour)
    • Use Home Assistant setting if entity is missing temperature_unit
    • Force Celsius if missing
    • Force Fahrenheit if missing

How to get the HA configuration:

Note: the °C / °F handling is not yet fully working in firmware 1.3.x. This is currently being worked on.

@zehnm zehnm added the enhancement New feature or request label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant