Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion % on tool cards show 100% even if there are missing checks/alignments. #6251

Closed
cckozie opened this issue Jul 15, 2019 · 3 comments

Comments

@cckozie
Copy link

cckozie commented Jul 15, 2019

As a checker or aligner I don't want the % complete on the tool cards to show 100% until every check/alignment for the tool have been completed so that I am not fooled into thinking projects are complete when they are not.

I'm assuming that 100% is being shown for incomplete projects because of rounding.
Suggest truncating instead of rounding.

May want to consolidate with #4414.

@cckozie
Copy link
Author

cckozie commented Sep 9, 2019

Still a problem in 2.0.0 (ca6c273)
17:21 is not fully aligned in this project, yet the wA tool card shows 100%
en_ult_mat_book 2.zip

@PhotoNomad0
Copy link
Contributor

Verified in translationCore 2.0.0 (697040c)

@cckozie
Copy link
Author

cckozie commented Oct 21, 2019

Looks good in 2.0.0 (f5ff634)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants