Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quick toggle to expanded scripture pane to show raw USFM #7226

Closed
PhotoNomad0 opened this issue Jan 31, 2022 · 5 comments
Closed

Add quick toggle to expanded scripture pane to show raw USFM #7226

PhotoNomad0 opened this issue Jan 31, 2022 · 5 comments
Assignees
Labels

Comments

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Jan 31, 2022

Story Explanation

User Story

Suggested by Larry at January meeting. Larry reviewed the prototype.

Added toggle button to title bar to switch to show raw USFM.

Regular view:
Screen Shot 2022-02-03 at 11 26 41 AM

Normal view:
Screen Shot 2022-02-03 at 11 27 00 AM

Features / Specifications

  • [ ]
  • [ ]
  • [ ]

Definition of Done

  • [ ]
  • [ ]
  • [ ]

Additional Context

Mockups

@PhotoNomad0 PhotoNomad0 self-assigned this Jan 31, 2022
@elsylambert
Copy link

@PhotoNomad0 The toggle state is not persistent when the expanded scripture pane is closed. Is it designed that way? If so, I will write up a separate issue for this.

@PhotoNomad0
Copy link
Contributor Author

@elsylambert I have not had a user request for that feature.

@elsylambert
Copy link

elsylambert commented Feb 8, 2022

translationCore 3.2.0 (ae2304b). USFM formatting fails when selection is made.
In tW, the new line added is not shown in the expanded Scripture view.
Large GIF (912x476)

@PhotoNomad0
Copy link
Contributor Author

@elsylambert Try again in latest build.

@elsylambert
Copy link

Works fine in translationCore 3.2.0 (1ed3822). Not seeing formatting issues. Toggle works well for the USFM view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants