Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag template is not used for version name and compare changes link in markdown #254

Closed
JaZo opened this issue Jan 23, 2025 · 0 comments · Fixed by #255
Closed

Tag template is not used for version name and compare changes link in markdown #254

JaZo opened this issue Jan 23, 2025 · 0 comments · Fixed by #255
Labels
bug Something isn't working

Comments

@JaZo
Copy link
Contributor

JaZo commented Jan 23, 2025

Environment

Package version: v0.5.7
Node: v22.12.0

Reproduction

  1. add the following config to remove the 'v' prefix:
{
  "templates": {
    "commitMessage": "chore(release): {{newVersion}}",
    "tagMessage": "{{newVersion}}",
    "tagBody": "{{newVersion}}"
  }
}
  1. release a new version: npx --yes changelogen@latest --release;
  2. see the tag is created without the 'v' prefix;
  3. see the version name and compare changes link in the markdown do include the 'v' prefix.

Describe the bug

#68 introduced the possibility to customize the commit message, tag name and tag message, but these templates aren't used everywhere. Especially in the compare changes link, resulting in a broken link.

I'll open a PR with a fix!

Additional context

No response

Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant